Skip to content

Commit

Permalink
Fix flaky MLS conversation creation test (#2386)
Browse files Browse the repository at this point in the history
The assertion was (very rarely) picking up a connection event between
alice and bob, and failing. Since bob is irrelevant to the test, this
commit removes bob and the related assertion altogether.
  • Loading branch information
pcapriotti authored May 11, 2022
1 parent 2b4cfe7 commit ed478cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions changelog.d/5-internal/mls-flaky-conversation
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix flaky MLS conversation creation test
5 changes: 1 addition & 4 deletions services/galley/test/integration/API/MLS.hs
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,14 @@ postMLSConvOk :: TestM ()
postMLSConvOk = do
c <- view tsCannon
qalice <- randomQualifiedUser
bob <- randomUser
let alice = qUnqualified qalice
let nameMaxSize = T.replicate 256 "a"
connectUsers alice (list1 bob [])
WS.bracketR2 c alice bob $ \(wsA, wsB) -> do
WS.bracketR c alice $ \wsA -> do
rsp <- postConvQualified alice defNewMLSConv {newConvName = checked nameMaxSize}
pure rsp !!! do
const 201 === statusCode
const Nothing === fmap Wai.label . responseJsonError
cid <- assertConv rsp RegularConv alice qalice [] (Just nameMaxSize) Nothing
WS.assertNoEvent (2 # WS.Second) [wsB]
checkConvCreateEvent cid wsA

testLocalWelcome :: TestM ()
Expand Down

0 comments on commit ed478cc

Please sign in to comment.