Fix message acks on wrong rabbitmq channels #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
akshaymankar
requested changes
Dec 4, 2024
pcapriotti
force-pushed
the
rabbitmq-acks
branch
from
b200d04 to
6238075
Compare
akshaymankar
approved these changes
Dec 11, 2024
Co-authored-by: Akshay Mankar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the way client acks are delivered to rabbitmq. When a channel dies and is replaced by a new one, it can happen that acks that were in flight are delivered to the wrong channel. This is bad, because it can cause the wrong message to be acked, or the channel to be forcibly closed by the rabbitmq server.
The fix is to simply control whether channel reconnection is enabled based on a new
enableRetryflag in the connection pool. For cannon pools, this flag is always set toFalse, thereby disabling reconnection completely, and letting the client handle any rabbitmq disconnection by creating a new websocket connection.Setting the flag to
Truecan be useful if/when the rabbitmq connection pool is used in background worker or other services.https://wearezeta.atlassian.net/browse/WPB-11491
Checklist
changelog.d