WPB-14306 [enterprise login] Implement common prerequisites for multiple endpoints #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
battermann
force-pushed
the
WPB-14306-be-implement-common-prerequisites-for-multiple-endpoints
branch
from
4e8d1a4 to
43678eb
Compare
battermann
force-pushed
the
WPB-14306-be-implement-common-prerequisites-for-multiple-endpoints
branch
from
e56f371 to
6d32c35
Compare
fisx
reviewed
Dec 11, 2024
fisx
reviewed
Dec 11, 2024
fisx
approved these changes
Dec 11, 2024
| {-# LANGUAGE OverloadedRecordDot #-} | ||
| {-# OPTIONS_GHC -Wno-ambiguous-fields #-} | ||
|
|
||
| module Wire.EnterpriseLoginSubsystem.Interpreter |
There was a problem hiding this comment.
i didn't check every details of this module against the RFC. (should i? probably...)
libs/wire-subsystems/src/Wire/EnterpriseLoginSubsystem/Interpreter.hs
Outdated
Show resolved
Hide resolved
| . userSubsystemInterpreter | ||
| . runTeamInvitationSubsystem teamInvitationSubsystemConfig | ||
| . authSubsystemInterpreter | ||
| ) | ||
| ) | ||
| $ runReaderT ma e | ||
|
|
||
| mkEnterpriseLoginSubsystemConfig :: Env -> Maybe EnterpriseLoginSubsystemConfig | ||
| mkEnterpriseLoginSubsystemConfig env = do |
There was a problem hiding this comment.
i would have made a missing audit-email field an error, unless it is explicitly stated in the RFC that we should silently stop sending emails.
There was a problem hiding this comment.
The problem with that is that not all environments are going to have this feature. Still a valid remark!
battermann
deleted the
WPB-14306-be-implement-common-prerequisites-for-multiple-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-14306
Checklist
changelog.d