-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump nixpkgs #4365
Merged
Merged
bump nixpkgs #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Dec 10, 2024
fisx
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! i'll look into the failing test cases on CI and see if i can get it green.
integration tests fail locally as well. looking into it. |
The constructor changed, the helper does the same thing anyway
The error throwing/catching/rendering flow doesn't seem to work anymore for the case where the handler is matched. Use a regular handler instead, because that's cleaner anyways.
supersven
force-pushed
the
WPB-14537-bump-nixpkgs
branch
from
December 13, 2024 09:04
bdf2d1f
to
1c4c1e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to get this fix NixOS/nixpkgs#358812 which is included in this bump.
We're experiencing the problem, see https://wearezeta.atlassian.net/browse/WPB-14537
Checklist
changelog.d