Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientAPI: Include unnesting of capabilties in V7, ensure consumable notifs are not part of the enum #4366

Merged
merged 10 commits into from
Dec 11, 2024
Merged

ClientAPI: Include unnesting of capabilties in V7, ensure consumable notifs are not part of the enum #4366

merged 10 commits into from
Dec 11, 2024

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Dec 10, 2024 •
edited
Loading

  • The V7 swagger seems to have changed more than I expected so this needs to be looked into.
    This was because v6 swagger was committed as v7 by mistake.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 10, 2024
fisx
fisx reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it all looks pretty reasonable to me except for the swagger output. hm...

services/brig/docs/swagger-v7.json Show resolved Hide resolved
services/brig/docs/swagger-v7.json Show resolved Hide resolved
@fisx fisx force-pushed the fix-v7-client-caps branch from 4e5b3a2 to 4432e83 Compare December 11, 2024 08:29
@akshaymankar akshaymankar marked this pull request as ready for review December 11, 2024 09:52
@akshaymankar akshaymankar requested a review from fisx December 11, 2024 09:52
@akshaymankar akshaymankar merged commit 2922137 into develop Dec 11, 2024
11 checks passed
@akshaymankar akshaymankar deleted the fix-v7-client-caps branch December 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaymankar @fisx @zebot