Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLS: Make missing MLS removal keys a template error #4369

Merged
merged 3 commits into from
Dec 11, 2024
Merged

MLS: Make missing MLS removal keys a template error #4369

merged 3 commits into from
Dec 11, 2024

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Dec 11, 2024 •
edited
Loading

This PR

  • forces the MLS removal key to be provided for all ciphersuites at template time. Without this PR missing keys become a runtime error.
  • adds missing documentation on how to generate MLS removal keys

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 11, 2024
akshaymankar
akshaymankar approved these changes Dec 11, 2024
View reviewed changes
changelog.d/5-internal/mls Outdated Show resolved Hide resolved
@smatting smatting merged commit 566762d into develop Dec 11, 2024
9 of 11 checks passed
@smatting smatting deleted the smatting/mls-removal-keys-config branch December 11, 2024 10:45
@zebot zebot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @akshaymankar @zebot