Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration/testConsumeTempEvents: Remove race causing flaky test #4372

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

akshaymankar
Copy link
Member

The creation of temp queue races with client creation event. This is removed by first expecting the event to be served to the real client and then listening to events temporarily

Fixup for #4360

https://wearezeta.atlassian.net/browse/WPB-11173

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d No changelog.
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Dec 12, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 12, 2024
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this! LGTM 👍

The creation of temp queue races with client creation event. This is removed by
first expecting the event to be served to the real client and then listening to
events temporarily
@akshaymankar akshaymankar force-pushed the fix-temp-client-integration-test branch from 0b2cbe1 to 93828eb Compare December 17, 2024 15:31
@akshaymankar akshaymankar merged commit 102a274 into develop Dec 18, 2024
11 checks passed
@akshaymankar akshaymankar deleted the fix-temp-client-integration-test branch December 18, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants