Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-14307] Makefile tweaks #4399

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[WPB-14307] Makefile tweaks #4399

wants to merge 2 commits into from

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Jan 6, 2025

see also commit messages.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

fisx added 2 commits January 6, 2025 17:12
@fisx
Walk filesystem with treefmt, not git.
a5f37d2 
Needed to catch enterprise services as submodule.
@fisx
Make make faster.
e526e9c 
target `c` depended on `treefmt`, which has been observed to add
several seconds to the develop cycle.  this change makes sure treefmt
is called on ci, but if you want to call it locally, run `make
sanitize-pr`.
@fisx fisx requested a review from a team January 6, 2025 16:25
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 6, 2025
@fisx fisx changed the title Makefile tweaks [WPB-14307] Makefile tweaks Jan 6, 2025
@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisx @zebot