Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write missing examples from the addon's data folder #33

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

DerelictDrone
Copy link
Member

@DerelictDrone DerelictDrone commented Dec 10, 2023

Fixes examples from #25 and #30 not showing up as well as any future changes to the whitelisted folders in data_static

I don't necessarily know if this will find them from a mounted gma, but if this was how it worked while it was in the workshop I don't doubt it'll work now

Provides a more satisfactory solution to fix #32 than the earlier one

@DerelictDrone DerelictDrone changed the title Force data write & regenerate default data files for the nov-dec examples. Write missing examples from the addon's data folder Dec 10, 2023
@thegrb93
Copy link
Contributor

So this reads files from data_static and writes them to data? Why not just have the files in data?

@thegrb93
Copy link
Contributor

Is it because data files don't get mounted by the client?

@DerelictDrone
Copy link
Member Author

So this reads files from data_static and writes them to data? Why not just have the files in data?
Is it because data files don't get mounted by the client?

These need to be in the user's own garrysmod/data folder I believe, since I don't think the wire text editor/e2 editor can access the data files from the mounted addon

As a matter of fact, this is actually an improvement over what E2 is doing right now, they're still using a "data decompressor" that checks if one of the examples is missing before copying over.

@thegrb93
Copy link
Contributor

Ok, I see why we're writing the files now. I'm still not sure why data was changed to data_static though.

@DerelictDrone
Copy link
Member Author

DerelictDrone commented Dec 11, 2023

I think Vurv wanted me to do that, though I'm not too sure on if it's a preference or if it's actually required for the workshop to allow the .txt files

@DerelictDrone DerelictDrone deleted the bring-examples-forth branch January 1, 2024 10:46
@DerelictDrone DerelictDrone restored the bring-examples-forth branch January 1, 2024 10:46
@DerelictDrone DerelictDrone reopened this Jan 1, 2024
@DerelictDrone DerelictDrone merged commit 78172d5 into wiremod:master Jan 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples from data folder don't automatically update
2 participants