open history with open end date by default #329
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also refactor chunk splitting
KraPete
requested changes
Jun 6, 2022
There was a problem hiding this comment.
Было бы отлично в интерфейсе, если конечное время не установлено, писать 'Текущее время' или 'Сейчас'. Иначе не ясно сходу, что означает пустая дата. Кстати, если задать время конца без даты, оно фактически сбрасывается. Тогда уж не давать задавать время, если дата не задана.
| params.timestamp.lt = endDate.getTime() / 1000/// + 86400; | ||
| var intervalMs = endDate - startDate; // duration of requested interval, in ms | ||
| } else { | ||
| console.log(new Date()); |
| @@ -1,3 +1,9 @@ | |||
| wb-mqtt-homeui (2.37.3) stable; urgency=medium | |||
There was a problem hiding this comment.
2.37.1 ?
Но вообще это же новая фича. Я бы сделал 2.38.0
| if (diffDays <= days) return [_start, end]; | ||
| var ret = [_start]; | ||
| var iter = Math.floor(diffDays / days) + 1; | ||
| console.log(iter); |
| if (diffDates <= days) return [start,end]; | ||
| var ret = [start]; | ||
| var iter = Math.floor(diffDates / days) + 1; | ||
| var _start = start ? start : new Date(+_end - 24 * 60 * 60 * 1000 * rangInterval); |
There was a problem hiding this comment.
24 * 60 * 60 * 1000 стоит в константу обернуть, а то оно в 3-х местах используется
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also refactor chunk splitting