Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node/yarn to the docker image #2851

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Add node/yarn to the docker image #2851

merged 1 commit into from
Dec 23, 2022

Conversation

AlexITC
Copy link
Contributor

@AlexITC AlexITC commented Dec 22, 2022 •
edited
Loading

These tools are required to deal with some scala.js projects.

See wiringbits/scala-webapp-template#298

NOTE:

@AlexITC
Add node/yarn to the docker image
42afa22 
These tools are required to deal with some scala.js projects.

See wiringbits/scala-webapp-template#298
@AlexITC AlexITC mentioned this pull request Dec 22, 2022
Open
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 82.45% // Head: 82.45% // No change to project coverage 👍

Coverage data is based on head (42afa22) compared to base (b483de7).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2851   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files         152      152           
  Lines        2946     2946           
  Branches      187      187           
=======================================
  Hits         2429     2429           
  Misses        517      517

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

fthomas
fthomas approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about Docker, but this looks good to me.

@fthomas fthomas added the build label Dec 22, 2022
@fthomas fthomas added this to the 0.18.0 milestone Dec 22, 2022
@fthomas fthomas merged commit c81ab90 into scala-steward-org:main Dec 23, 2022
@AlexITC AlexITC deleted the add-yarn-to-docker-image branch December 23, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fthomas fthomas fthomas approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

Scala steward is not updating due to build errors
2 participants
@AlexITC @fthomas