Add caching for sbt dependencies and build artifacts (Issue #342) #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexITC
reviewed
Mar 17, 2023
| - name: Cache sbt dependencies | ||
| uses: actions/cache@v2 | ||
| with: | ||
| path: | |
There was a problem hiding this comment.
Actually, these items are already cached by other actions
AlexITC
reviewed
Mar 17, 2023
| - name: Cache sbt build artifacts | ||
| uses: actions/cache@v2 | ||
| with: | ||
| path: | |
There was a problem hiding this comment.
These could be helpful but they don't really reduce the build time by much (~2m), I have an internal version which I'll push
There was a problem hiding this comment.
Thank you for your reply, Alex. I appreciate your feedback on the pull request and it's great to hear that you have an internal version that can further improve the build time. In that case, would you like me to close this pull request for now? Please let me know your thoughts
|
Superseded by 729c98a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Issue #342 )
This pull request adds caching steps to the CI workflow to reduce the time and bandwidth needed for each job. It uses the actions/cache@v2 action to cache the sbt dependencies and build artifacts based on the hash of the sbt files and the operating system. This can improve the performance and reliability of the CI workflow.