Skip to content
This repository has been archived by the owner on Dec 15, 2024. It is now read-only.

1.20.3/4 #36

Merged
merged 4 commits into from
Dec 20, 2023
Merged

1.20.3/4 #36

merged 4 commits into from
Dec 20, 2023

Conversation

Kas-tle
Copy link
Contributor

@Kas-tle Kas-tle commented Dec 18, 2023

No description provided.

@Kas-tle Kas-tle marked this pull request as draft December 18, 2023 09:40
@Kas-tle
Copy link
Contributor Author

Kas-tle commented Dec 18, 2023

Pending issue with Fabric retained payload on CustomPayloadC2SPacket:

And issue with owo-lib rich text being broken for entries with index but no text.

BasiqueEvangelist
BasiqueEvangelist approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@BasiqueEvangelist BasiqueEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (apart from the en_us.json changes, but those shouldn't be needed after the owo-lib issue is fixed)

@Kas-tle
rev lang changes + update owo
5b7563f 
Signed-off-by: Joshua Castle <[email protected]>
@BasiqueEvangelist BasiqueEvangelist changed the base branch from 1.20.2 to 1.20.3 December 20, 2023 19:58
@Kas-tle
Copy link
Contributor Author

Kas-tle commented Dec 20, 2023

Requires wisp-forest/owo-lib#204

@BasiqueEvangelist BasiqueEvangelist marked this pull request as ready for review December 20, 2023 20:04
@BasiqueEvangelist BasiqueEvangelist merged commit a118e20 into wisp-forest:1.20.3 Dec 20, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BasiqueEvangelist BasiqueEvangelist BasiqueEvangelist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kas-tle @BasiqueEvangelist