refactor: extract inlined shell script in action to own file #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried a couple other things before going with environment variables to pass args into the shell script.
using positional arguments didn't work because in order for the postfix to work, the prefix can't be set and passing an empty string didn't work, so whatever was set for the postfix argument would end up as the prefix.
I tried using single char flags (ie.
-f
for filename) like this:and in the script:
but faced the same problem... if
inputs.prefix
was unset,-x
would end up being the value passed into-p
and so you'd end up with_X_NODEJS
etc.there's probably something better than environment variables but this works