Home

Welcome to the adt-utils wiki!

Nice checkins Will. When I see a commit message about improving performance, I expect to see some before/after numbers from some sort of test. Nothing beats at least rudimentary quantification.

I used valgrind to test for memory leaks.

I'm not crazy about increasing use of printf. I kind of think the openhash code itself shouldn't even include stdio.h and any output should be done via callback.

---

Yep, I forgot to record timing before I changed anything. Will do so in the future. I doubt I did anything significant either; just got rid of a float cast or two, eliminated an unnecessary memset, etc.

All use of printf is in the debug_* functions. When we put this into production, we can do a string-replace on the source code and change debug_* to just *, and it will work exactly the same but with no fprintfs.