Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@astrojs/upgrade should check if the current directory has astro installed #12535

Closed
WesSouza opened this issue Nov 26, 2024 · 0 comments · Fixed by #12576
Closed

@astrojs/upgrade should check if the current directory has astro installed #12535

WesSouza opened this issue Nov 26, 2024 · 0 comments · Fixed by #12576
Labels
- P2: nice to have Not breaking anything but nice to have (priority) pkg: upgrade Related to `@astrojs/upgrade` (scope)

Comments

@WesSouza
Copy link
Contributor

WesSouza commented Nov 26, 2024 •
edited
Loading

Astro Info

Astro                    v5.0.0-beta.11
Node                     v20.18.0
System                   macOS (arm64)
Package Manager          pnpm
Output                   server
Adapter                  @astrojs/vercel
Integrations             @astrojs/solid-js

Describe the Bug

Running pnpm dlx @astrojs/upgrade beta on a directory that does not have Astro installed shows a confirmation that all updates were done.

What's the expected result?

The script should error saying it couldn't find an Astro installation.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Nov 26, 2024
@ascorbic ascorbic added - P2: nice to have Not breaking anything but nice to have (priority) pkg: upgrade Related to `@astrojs/upgrade` (scope) and removed needs triage Issue needs to be triaged labels Nov 29, 2024
@apatel369 apatel369 mentioned this issue Nov 30, 2024
Merged
apatel369 added a commit to apatel369/astro that referenced this issue Dec 3, 2024
@apatel369
Merge branch 'main' into arpan-withastro#12535-check
10eeb28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P2: nice to have Not breaking anything but nice to have (priority) pkg: upgrade Related to `@astrojs/upgrade` (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(upgrade): verify astro installation before upgrade to prevent false success apatel369/astro
2 participants
@WesSouza @ascorbic