fix(upgrade): verify astro installation before upgrade to prevent false success
#12576
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bluwy
approved these changes
Dec 2, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12535
Changes
This PR addresses the issue where running
upgradeon a directory without an Astro installation would incorrectly confirm that all updates were done. It now throws an error if Astro is not installed.Check video below:
basicsdir hasastroinstalled so it does not throw errors and proceed.astro-forkdir does not haveastroinstalled so it stops with an error.Screen.Recording.2024-11-30.at.4.46.20.PM.mov
Testing
Manually tested
Docs
N/A bug fix