Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error for inferSize and Image component #11823

Merged
merged 6 commits into from
Oct 16, 2024
Merged

fix: improve error for inferSize and Image component #11823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98fbc41
fix: improve error for inferSize and Image component
DerTimonius Aug 23, 2024
535ca25
add changeset
DerTimonius Aug 23, 2024
fe23ea2
Merge branch 'main' into 11821-inferSize-error-local-image
DerTimonius Aug 28, 2024
2253d35
Merge branch 'main' of https://github.com/withastro/astro into 11821-…
DerTimonius Oct 12, 2024
e60d305
move isRemovePath check
DerTimonius Oct 12, 2024
63fcf6f
Merge branch 'main' into 11821-inferSize-error-local-image
Princesseuh Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-flowers-destroy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

fix: improve error message when inferSize is used in local images with the Image component
7 changes: 6 additions & 1 deletion packages/astro/src/assets/internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { isRemotePath } from '@astrojs/internal-helpers/path';
import type { AstroConfig } from '../@types/astro.js';
import { AstroError, AstroErrorData } from '../core/errors/index.js';
import { DEFAULT_HASH_PROPS } from './consts.js';
Expand Down Expand Up @@ -65,7 +66,11 @@ export async function getImage(
};

// Infer size for remote images if inferSize is true
if (options.inferSize && isRemoteImage(resolvedOptions.src)) {
if (
options.inferSize &&
isRemoteImage(resolvedOptions.src) &&
isRemotePath(resolvedOptions.src)
) {
const result = await inferRemoteSize(resolvedOptions.src); // Directly probe the image URL
resolvedOptions.width ??= result.width;
resolvedOptions.height ??= result.height;
Expand Down
Loading