-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): pass search params to fallback #12547
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a0b65cc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
CodSpeed Performance ReportMerging #12547 will degrade performances by 35.22%Comparing Summary
Benchmarks breakdown
|
This looks good. Could you add a test for this? Probably in |
@ematipico this seems to be your baby - any concerns? |
Changes
Testing
Tested locally with the same code in the stackblitz example in issue. Ran all i18n test suites. Did not add a specific test for this - if maintainers want I will, but wanted feedback on willingness to include this before I dove into the fixtures.
Docs
/cc @withastro/maintainers-docs for feedback!
May need docs. The current behavior is also undocumented and imo less intuitive.