Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not freeze process.env in dev #12585

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Dec 2, 2024

Changes

  • In dev, use globalThis
  • Closes PLT-2684

Testing

  • Tests should still pass
  • Test manually
  • Test on a private project

Docs

N/A

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: d9c3415

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 2, 2024
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #12585 will degrade performances by 91.99%

Comparing fix/astro-env-dev (d9c3415) with main (10c6b8d)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 3 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/astro-env-dev Change
Rendering: streaming [false], .astro file 1.9 s 1.5 s +26.37%
Rendering: streaming [false], .md file 14.8 ms 185 ms -91.99%
Rendering: streaming [false], .mdx file 1.3 s 1.1 s +26.13%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant