-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new allowedHosts
option
#13278
Conversation
🦋 Changeset detectedLatest commit: d11d3e4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
7e674ad
to
84d8fcf
Compare
CodSpeed Performance ReportMerging #13278 will not alter performanceComparing Summary
|
astro
@astrojs/cloudflare
@astrojs/netlify
@astrojs/node
@astrojs/vercel
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my concern is that we are a bit conflicting with the vite option. What happens to it? Is it not used at all anymore? Should we warn if used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just left some nit related to the doc.
Co-authored-by: Armand Philippot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great here, just some small thoughts!
Fun fact, I literally just configured vite.server.allowHosts
myself yesterday to allow my dev server to work in Gitpod 😄
Also noting that I didn't notice any new error messages added along with this feature.
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
Closes #13060
This PR adds a new
allowedHosts
and--allowed-hosts
options.This options isn't passed to the node adapter yet, we will have to figure out how to use it in the preview server.
Testing
I don't know how to test this functionality, help would be appreciated.
Docs
Will send a PR