Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assets): export again asset utilities #13336

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

ematipico
Copy link
Member

Changes

Closes #13335

Testing

I'll make a preview release and ask the user to test it

Docs

We should document these utilities somewhere, but to be honest, I don't know where. 😅 I'm happy to send a PR given the proper directions.

Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: f651536

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ematipico ematipico added the pr preview This PR has a preview release label Feb 28, 2025
@ematipico ematipico self-assigned this Feb 28, 2025
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 28, 2025
Copy link

pkg-pr-new bot commented Feb 28, 2025

astro

npm i https://pkg.pr.new/astro@13336

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13336

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13336

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13336

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13336

commit: f651536

Copy link

codspeed-hq bot commented Feb 28, 2025

CodSpeed Performance Report

Merging #13336 will not alter performance

Comparing fix/regression-remote-pattern (f651536) with main (5f72a58)

Summary

✅ 6 untouched benchmarks

@Princesseuh
Copy link
Member

@ematipico
Copy link
Member Author

I will do a separate PR for docs, because these functions don't have JSDoc too.

@Princesseuh how does a user import these utilities?

@ematipico ematipico merged commit 8f632ef into main Feb 28, 2025
18 checks passed
@ematipico ematipico deleted the fix/regression-remote-pattern branch February 28, 2025 14:39
@astrobot-houston astrobot-houston mentioned this pull request Feb 28, 2025
@Princesseuh
Copy link
Member

Must be something like import { something } from 'astro/assets/utils' I'd assume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr preview This PR has a preview release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro 5.4 breaks custom Image Services
3 participants