bugfix(svelte): fix colliding id's generated from $props.id
#13339
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zing the new `uidPrefix` option exposed for both server and client side rendering.
🦋 Changeset detectedLatest commit: 94b8c20 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: svelte
|
@Hugos68 ping me when the related svelte PR is merged and released |
|
@florian-lefebvre Merged and released in: sveltejs/svelte#15428. API is available in version 5.22.0! |
|
I'll aim to update my PR and will request a review after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13327
Utilizes the new
uidPrefixoption from server/client side rendering added in sveltejs/svelte#15403 in Svelte to inject a unique prefix generated by Astro.Note: The linked PR has not been merged yet, we would need to wait until the next version of Svelte releases and install that version, until then this PR will remain a draft.
Changes
$props.idTesting
No tests were added because it looks like the Svelte integration isn't tested, at all?
Docs
This would only solve problems, it's highly unlikely a user depended on colliding ID's for their app to work. It's also a very niche use case using two client side Astro Svelte components with
$props.id