Update CSS, add vite ignore flags to dynamic imports #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e usable for dev instead of including a playground
commit: |
jdtjenkins
approved these changes
Jan 5, 2025
louisescher
approved these changes
Jan 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and improvements to the
@studiocms/markdown-remarkpackage, focusing on CSS changes, dynamic import handling, and enhancements to the Astro integration tests. The most important changes include adding flags to prevent Vite dynamic import warnings, updating CSS, and refactoring Astro integration tests to use a new layout component.Dynamic Import Handling:
/* @vite-ignore */flags to dynamic imports inimport-plugin-browser.tsandimport-plugin-default.tsto prevent Vite warnings. [1] [2]CSS Updates:
headings.cssby removing unused media queries and CSS rules. [1] [2]Astro Integration Tests:
Layoutcomponent for consistent HTML structure. [1] [2] [3] [4]md.txtfiles to improve test coverage and ensure proper rendering.Miscellaneous:
package.jsonscripts to streamline the development process and ensure all relevant packages are included in thedevscript.layout.astrofile to define the layout structure used across multiple test pages.