Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Custom components #8

Merged
merged 17 commits into from
Jan 6, 2025
Merged

Feat Custom components #8

merged 17 commits into from
Jan 6, 2025

Conversation

Adammatthiesen
Copy link
Member

@Adammatthiesen Adammatthiesen commented Jan 6, 2025

This pull request introduces significant enhancements to the Markdown Remark processor Astro Integration, allowing for more flexible and powerful Markdown rendering with custom components. The most important changes include the addition of custom components support, updates to the integration and documentation, and the introduction of new dependencies.

New Features:

  • Added custom components support in the Markdown Remark processor Astro Integration.
  • Introduced utility functions in utils.ts for component proxy creation, indentation handling, dedenting strings, and merging records.
  • Moved zod schema to a separate schema.ts file.

Integration Updates:

  • Enhanced Astro integration to support custom components configuration via astro.config.mjs. [1] [2]
  • Updated markdown.ts to include custom components during Markdown rendering. [1] [2]
  • Extended index.ts to utilize the new schema and utilities. [1] [2]

Documentation:

  • Updated README.md with instructions for setting up custom components in Astro integration. [1] [2]

Dependencies:

  • Added entities and ultrahtml as new dependencies. [1] [2] [3]

- Add a new custom component called "Custom" to the markdown-remark integration in Astro.
- The custom component is defined in the file "packages/markdown-remark/tests/fixture/astro/src/pages/custom-components/_comps/Custom.astro".
- This component will be used when processing markdown content.
Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: 7125e52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@studiocms/markdown-remark Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 6, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@studiocms/markdown-remark@8

commit: ccfbf94

@Adammatthiesen Adammatthiesen marked this pull request as ready for review January 6, 2025 06:48
@Adammatthiesen Adammatthiesen requested a review from a team as a code owner January 6, 2025 06:48
louisescher
louisescher previously approved these changes Jan 6, 2025
@Adammatthiesen Adammatthiesen merged commit 6b0053b into main Jan 6, 2025
6 checks passed
@Adammatthiesen Adammatthiesen deleted the feat-componentmap branch January 6, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants