Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 First beta #189

Merged
merged 11 commits into from
Jul 24, 2024
Merged

📝 First beta #189

merged 11 commits into from
Jul 24, 2024

Conversation

create-issue-branch[bot]
Copy link
Contributor

Original issue description

This issue is to cover the scope to first release to our FIRST BETA now that we are ready to move on to the next milestone of our project.

[!IMPORTANT]
This issue is the Current Tracker for all the final bits and pieces that will lead up to the First Beta release of StudioCMS!

In Progress:

  • version/publish first beta version and update docs to remove banners stating no version published (This issue)

Complete:

closes #98

@create-issue-branch create-issue-branch bot added the TRACKER Status tracker / issue tracker label Jul 23, 2024
@create-issue-branch create-issue-branch bot changed the title First beta ✨ First beta Jul 23, 2024
@create-issue-branch create-issue-branch bot changed the title First beta ✨ First beta Jul 23, 2024
@create-issue-branch create-issue-branch bot changed the title ✨ First beta 📝 First beta Jul 23, 2024
@Adammatthiesen Adammatthiesen added documentation Improvements or additions to documentation in progress labels Jul 23, 2024
@Adammatthiesen Adammatthiesen marked this pull request as ready for review July 23, 2024 20:25
@Adammatthiesen Adammatthiesen requested review from a team July 23, 2024 20:25
@Adammatthiesen
Copy link
Member

Final Docs review, than we will version and publish before merge!

  • StudioCMS: v0.1.0-beta.1
  • StudioCMSBlog: v0.1.0-beta.1

dreyfus92
dreyfus92 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

dreyfus92
dreyfus92 reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this 😥

www/docs/src/content/docs/start-here/getting-started.mdx Outdated Show resolved Hide resolved
TheOtterlord
TheOtterlord approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to have to review the usage of asides in these docs 😅
But these changes look good to me! Just one small suggestion.

www/docs/src/content/docs/start-here/getting-started.mdx Outdated Show resolved Hide resolved
BryceRussell
BryceRussell approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@BryceRussell BryceRussell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the configuration reference should all be on one page, but other than that, LGTM!

@Adammatthiesen
update config reference to use a primary point of entry to start from…
00c553e 
… instead of it being just a bunch of autogenerated non-sense
@Adammatthiesen
Copy link
Member

I think the configuration reference should all be on one page, but other than that, LGTM!

There we go... 00c553e

jdtjenkins
jdtjenkins requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@jdtjenkins jdtjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adammatthiesen you wanted a review, you got one! 😄

www/docs/src/components/Youtube.astro Outdated Show resolved Hide resolved
www/docs/src/content/docs/config-reference/default-frontend-config.md Outdated Show resolved Hide resolved
www/docs/src/content/docs/config-reference/default-frontend-config.md Outdated Show resolved Hide resolved
www/docs/src/content/docs/config-reference/default-frontend-config.md Outdated Show resolved Hide resolved
www/docs/src/content/docs/config-reference/default-frontend-config.md Outdated Show resolved Hide resolved
www/docs/src/content/docs/config-reference/options-schema.md Outdated Show resolved Hide resolved
www/docs/src/content/docs/config-reference/options-schema.md Outdated Show resolved Hide resolved
www/docs/src/content/docs/index.mdx Show resolved Hide resolved
www/docs/src/content/docs/start-here/getting-started.mdx Outdated Show resolved Hide resolved
www/docs/src/content/docs/start-here/getting-started.mdx Outdated Show resolved Hide resolved
@Adammatthiesen @jdtjenkins @TheOtterlord
Apply suggestions from code review
0c117e9 
Co-authored-by: Jacob Jenkins <[email protected]>
Co-authored-by: Reuben Tier <[email protected]>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7459f9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jdtjenkins
jdtjenkins approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@jdtjenkins jdtjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥🔥🔥

@Adammatthiesen
Copy link
Member

!coauthor

@github-actions GitHub Actions
Copy link
Contributor 

Co-authored-by: Adam Matthiesen <[email protected]>
Co-authored-by: Jacob Jenkins <[email protected]>
Co-authored-by: Bryce Russell <[email protected]>
Co-authored-by: Reuben Tier <[email protected]>
Co-authored-by: Paul Valladares <[email protected]>

@Adammatthiesen Adammatthiesen merged commit 9cc719c into main Jul 24, 2024
1 check passed
@Adammatthiesen Adammatthiesen deleted the issue-0098 branch July 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 approved these changes

@TheOtterlord TheOtterlord TheOtterlord approved these changes

@Adammatthiesen Adammatthiesen Adammatthiesen left review comments

@BryceRussell BryceRussell BryceRussell approved these changes

@jdtjenkins jdtjenkins jdtjenkins approved these changes

Assignees

@Adammatthiesen Adammatthiesen

Labels
documentation Improvements or additions to documentation TRACKER Status tracker / issue tracker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First beta
5 participants
@Adammatthiesen @jdtjenkins @BryceRussell @TheOtterlord @dreyfus92