Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Overhaul #369

Merged
merged 49 commits into from
Nov 13, 2024
Merged

Auth Overhaul #369

merged 49 commits into from
Nov 13, 2024

Conversation

Adammatthiesen
Copy link
Member

@Adammatthiesen Adammatthiesen commented Oct 29, 2024

Closes #327
Closes #326

Partial #73
Partial #331

This pull request includes a comprehensive overhaul of the authentication system in the StudioCMS project, along with updates to dependencies and refactoring of various components. The most important changes include the introduction of new environment variables, removal of the old authentication system, addition of new components, updates to database schemas, and refactoring of dependencies in multiple packages.

Auth System Overhaul:

  • Environment Variables: Added CMS_ENCRYPTION_KEY and CMS_GITHUB_REDIRECT_URI to the astro:env schema for authentication purposes. [1] [2]
  • Components: Introduced new OAuthButton, OAuthButtonStack, and AuthLayout components, along with their associated CSS and scripts. [1] [2] [3]
  • Removal of Old System: Removed the Lucia based authentication system and associated files (lucia-astrodb-adapter, authHelper). [1] [2]
  • Database Schema Updates: Updated StudioCMSUsers table to remove OAuth IDs, added StudioCMSOAuthAccounts table for handling OAuth accounts, and updated StudioCMSPermissions and StudioCMSSiteConfig tables.

Dependency and Configuration Updates:

  • Dependency Updates: Updated dependencies in package.json files across multiple packages (@studiocms/auth, @studiocms/core, @studiocms/dashboard, @studiocms/ui). [1] [2] [3] [4]
  • Configuration Changes: Updated biome.json to adjust the list of ignored files.

These changes collectively aim to enhance the security, maintainability, and functionality of the StudioCMS authentication system.

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 3e6af40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@studiocms/dashboard Patch
@studiocms/auth Patch
@studiocms/core Patch
@studiocms/ui Patch
studiocms Patch
@studiocms/blog Patch
@studiocms/devapps Patch
@studiocms/frontend Patch
@studiocms/imagehandler Patch
@studiocms/renderers Patch
@studiocms/assets Patch
@studiocms/betaresources Patch
@studiocms/robotstxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@studiocms-no-reply
Copy link
Member

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

@Adammatthiesen
Copy link
Member Author

Demo for new login page (and auth system) is available at https://next-demo.studiocms.xyz/dashboard/login

oAuth is currently disabled due to other requirements for oAuth not being done yet(Dashboard stuff that will happen as part of the redesign)

Adammatthiesen and others added 2 commits November 4, 2024 07:17
- Adds a fallback image that displays when the Three.js context fails to render.
Copy link
Member

@louisescher louisescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://c.tenor.com/AV1JBkuCyTYAAAAd/tenor.gif

lgtm

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive refactor 🚢

@Adammatthiesen Adammatthiesen merged commit d0e965c into issue-0304 Nov 13, 2024
1 check passed
@Adammatthiesen Adammatthiesen deleted the update/authoverhaul branch November 13, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants