Feat/picker custom top element #3465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Jan 2, 2025
| @@ -122,6 +132,15 @@ export default class PickerScreen extends Component { | |||
| ); | |||
| }; | |||
|
|
|||
| handleTopElementPress = (allOptionsSelected: boolean, setValue: any) => { | |||
There was a problem hiding this comment.
We usually use on and not handle
| const {isMultiMode, value, setValue} = context; | ||
| if (customTopElement) { | ||
| if (isMultiMode) { | ||
| console.log(`renderCustomTopElement, isMultiMode!, value:`, value); |
| return customTopElement({value, setValue}); | ||
| } | ||
| //@ts-expect-error - PickerWithSingleValue props | ||
| return customTopElement(); |
There was a problem hiding this comment.
I don't like the difference in API
| /** | ||
| * Custom top element | ||
| */ | ||
| customTopElement?: () => React.ReactElement; |
There was a problem hiding this comment.
You're calling the prop customTopElement but it's actually a renderCustomTopElement (it's a function)
| if (isMultiMode) { | ||
| console.log(`renderCustomTopElement, isMultiMode!, value:`, value); | ||
| //@ts-expect-error - PickerWithMultiValue props need to pass the correct props | ||
| return customTopElement({value, setValue}); |
There was a problem hiding this comment.
We should avoid exposing internal workings on the components.
What if we want to change it in the future?
| /* | ||
| * Set the new multi draft value | ||
| */ | ||
| setValue: (value: PickerMultiValue) => void; |
There was a problem hiding this comment.
Let's remove the setValue and only expose the value, the user can set their internal state thus affecting the component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker new
customTopElement, onItemSelectionprops.onItemSelectionget's called when item selection toggled, and can indicate about thedraft valueof the multi picker.customTopElementwill be render above thePickerItemList, the custom element will get props only inMultiselection mode.Changelog
Picker support for new
customTopElementandonItemSelectioncallback function.Additional info
MADS-4575