Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firewall E2E Test under Windows Sandbox (with Windows Insider release) #586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Firewall E2E Test under Windows Sandbox (with Windows Insider release) #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/test/burn/WixTestTools/Firewall/UniqueCheck.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public UniqueCheck(RuleDetails details)
this.ApplicationName = details.ApplicationName;
this.LocalUserOwner = details.LocalUserOwner;
this.RemoteAddresses = details.RemoteAddresses;
this.Grouping = details.Grouping;
}


Expand All @@ -40,6 +41,8 @@ public UniqueCheck(RuleDetails details)

public string RemoteAddresses { get; set; }

public string Grouping { get; set; }

public bool FirewallRuleIsUnique(INetFwRule3 rule)
{
if (this.Name != null && rule.Name != this.Name)
Expand Down Expand Up @@ -77,6 +80,11 @@ public bool FirewallRuleIsUnique(INetFwRule3 rule)
return false;
}

if (this.Grouping != null && rule.Grouping != this.Grouping)
{
return false;
}

return true;
}
}
Expand Down
Loading