Raise conversion warning for After and Before attributes

[bevanweiss]

Raise conversion warning for After and Before attributes, at least on Sequence and SetProperty elements

[robmen]

This fixes issue 8898, correct? If so, please always add the following line as the last part of the PR message. It ties the PR to the issue and auto-closes it so we don't have to remember to do so later. :)

Fixes wixtoolset/issues#ISSUE_NUMBER_HERE

[bevanweiss]

This fixes issue 8898, correct? If so, please always add the following line as the last part of the PR message. It ties the PR to the issue and auto-closes it so we don't have to remember to do so later. :)

Fixes wixtoolset/issues#ISSUE_NUMBER_HERE

not quite... from the issue

Expected Result
The value WixQueryOsDirs should have been replaced with Wix4QueryOsDirs_$(sys.BUILDARCHSHORT).

This doesn't appear to be how the converter has previously handled these wix custom actions, and I've kept it similar.
So my PR just raises the warnings for the conversion locations, it doesn't automatically fix them.
Although that should be pretty straight forward to implement if that's the direction we'd want.

These would need to change to have _$(sys.BUILDARCHSHORT) in place of _<PlatformSuffix> for these

wix/src/wix/WixToolset.Converters/WixConverter.cs

Line 203 in 523c66a

{ "ConfigureComPlusUninstall", "Wix4ConfigureComPlusUninstall_<PlatformSuffix>" },

and an update of the attribute values, plus possibly removal of the warning.