-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto Query / Statement #118
base: master
Are you sure you want to change the base?
Conversation
Hey :D |
@ecourtial did fix the various issues with phpstan / phpunit / phpcsfixer and make infection working again in dev env :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leNEKO OK for me. Just need an update in the changelog :)
Huge work !
@leNEKO For the changelog, you don't have to be specific. Just put the overall idea. |
Here it is fad65cb?short_path=02aa01b#diff-02aa01b7a281606221d6b6141e30a15d4bb22a980ad403bde95b89aa3588213f let me know if it is enough :) |
@leNEKO Allright. |
@ecourtial ... i did some additional integration tests with this branch. It need more rework... i set this PR back in draft, and see if i can do something like suggested here #2 |
`
for table and column names (see Syntax error on Load if column is a reserved word (on more recent MariaDB) #117)Query
andStatement
classmake coverage
command in Makefilemake dev
nix shell command