This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
Ability to upload request body as iOS Upload Task #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables consistent indentation regardless of the default indentation settings on a developer's machine.
Comparing two `NSString` objects using pointer equality is undefined.
Rather than specifying an existing file to upload (using the `path` config option), this change adds the option to write the request body to a temporary file, and upload it using `NSURLSessionUploadTask`.
|
FYI react-native-fetch-blob has a new maintained location. Check out the README. Please consider submitting your PR there, this repository is unmaintained. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify
IOSUploadTaskas a config parameter toRNFetchBlobConfig. Specifying this parameter will create anNSURLSessionUploadTaskwith the request's body. If theIOSBackgroundTaskflag is also set, the body is first written to a temporary file. See commit log for more details.