update links to point to the new repo #4560
Conversation
WalkthroughThis pull request updates numerous documentation and configuration URLs throughout the repository to reflect a change in repository ownership—from “Aircoookie” to “wled-dev.” The modifications span issue templates, contributor guidelines, build configuration files, usermod documentation, and core source/data files. In addition, significant additions to LED effect functions and adjustments to effect implementation signatures were made in the main effects file. Most changes involve updating comment and URL references without impacting functional code. Changes
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
wled00/FX.cpp (1)
3814-3821:⚠️ Potential issueNew effect mode_2DAkemi() added
A new 2D effect called "Akemi" has been added. This effect creates an animated character display with audio reactivity.
The effect uses a hardcoded sprite array which could be moved to PROGMEM to save RAM.
Suggested fix:
-static uint8_t akemi[] = { +static const uint8_t akemi[] PROGMEM = {
🧹 Nitpick comments (3)
tools/cdata.js (1)
91-92: Consider enhancing URL replacement logic.The current implementation might miss some URL variations. Consider using a more robust approach:
- html = html.replaceAll("https://github.com/atuline/WLED", repoUrl); - html = html.replaceAll("https://github.com/wled-dev/WLED", repoUrl); + // Match URLs with or without protocol, www, and trailing slashes + const urlPatterns = [ + /https?:\/\/(www\.)?github\.com\/atuline\/WLED\/?/g, + /https?:\/\/(www\.)?github\.com\/wled-dev\/WLED\/?/g + ]; + urlPatterns.forEach(pattern => { + html = html.replace(pattern, repoUrl); + });CONTRIBUTING.md (1)
30-30: Format URL as a proper Markdown link.The bare URL should be formatted as a proper Markdown link for better readability and maintainability.
-You can find a collection of very useful tips and tricks here: https://github.com/wled-dev/WLED/wiki/How-to-properly-submit-a-PR +You can find a collection of very useful tips and tricks [here](https://github.com/wled-dev/WLED/wiki/How-to-properly-submit-a-PR).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
30-30: Bare URL used
null(MD034, no-bare-urls)
wled00/FX.cpp (1)
6079-6136: Text scrolling effect enhancedThe scrolling text effect now supports:
- Dynamic text formatting for date/time
- Custom text positioning and scrolling
- Multiple font sizes
Consider extracting the date/time formatting logic into a separate helper function to improve readability and maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (34)
.github/ISSUE_TEMPLATE/bug.yml(1 hunks)CONTRIBUTING.md(1 hunks)package.json(1 hunks)platformio_override.sample.ini(1 hunks)readme.md(1 hunks)tools/cdata.js(1 hunks)usermods/EXAMPLE_v2/usermod_v2_example.h(1 hunks)usermods/Fix_unreachable_netservices_v2/usermod_Fix_unreachable_netservices.h(1 hunks)usermods/PIR_sensor_switch/PIR_Highlight_Standby(1 hunks)usermods/PIR_sensor_switch/readme.md(1 hunks)usermods/PIR_sensor_switch/usermod_PIR_sensor_switch.h(1 hunks)usermods/TTGO-T-Display/usermod.cpp(1 hunks)usermods/TetrisAI_v2/readme.md(1 hunks)usermods/audioreactive/audio_reactive.h(1 hunks)usermods/buzzer/usermod_v2_buzzer.h(1 hunks)usermods/photoresistor_sensor_mqtt_v1/usermod.cpp(1 hunks)usermods/pixels_dice_tray/platformio_override.ini.sample(1 hunks)usermods/stairway_wipe_basic/stairway-wipe-usermod-v2.h(1 hunks)usermods/usermod_v2_word_clock/usermod_v2_word_clock.h(1 hunks)wled00/FX.cpp(1 hunks)wled00/FX_fcn.cpp(1 hunks)wled00/bus_manager.cpp(7 hunks)wled00/colors.cpp(1 hunks)wled00/data/common.js(1 hunks)wled00/data/index.htm(1 hunks)wled00/data/index.js(2 hunks)wled00/data/settings_dmx.htm(1 hunks)wled00/data/settings_sec.htm(1 hunks)wled00/data/update.htm(1 hunks)wled00/ir.cpp(1 hunks)wled00/usermod.cpp(1 hunks)wled00/util.cpp(1 hunks)wled00/wled.h(1 hunks)wled00/wled_eeprom.cpp(1 hunks)
✅ Files skipped from review due to trivial changes (30)
- usermods/PIR_sensor_switch/readme.md
- usermods/TTGO-T-Display/usermod.cpp
- wled00/colors.cpp
- usermods/stairway_wipe_basic/stairway-wipe-usermod-v2.h
- usermods/PIR_sensor_switch/PIR_Highlight_Standby
- wled00/util.cpp
- usermods/EXAMPLE_v2/usermod_v2_example.h
- usermods/photoresistor_sensor_mqtt_v1/usermod.cpp
- usermods/buzzer/usermod_v2_buzzer.h
- wled00/wled_eeprom.cpp
- wled00/data/common.js
- wled00/data/settings_dmx.htm
- wled00/wled.h
- usermods/TetrisAI_v2/readme.md
- usermods/Fix_unreachable_netservices_v2/usermod_Fix_unreachable_netservices.h
- wled00/data/index.htm
- wled00/ir.cpp
- .github/ISSUE_TEMPLATE/bug.yml
- platformio_override.sample.ini
- usermods/PIR_sensor_switch/usermod_PIR_sensor_switch.h
- wled00/data/update.htm
- wled00/usermod.cpp
- wled00/data/settings_sec.htm
- wled00/FX_fcn.cpp
- wled00/bus_manager.cpp
- usermods/usermod_v2_word_clock/usermod_v2_word_clock.h
- usermods/pixels_dice_tray/platformio_override.ini.sample
- wled00/data/index.js
- package.json
- usermods/audioreactive/audio_reactive.h
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CONTRIBUTING.md
30-30: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (7)
readme.md (1)
3-4: LGTM!The repository URL updates in the badges are consistent and accurate.
Also applies to: 9-9
wled00/FX.cpp (6)
1-11: License and attribution information updatedThe file header has been updated to include proper attribution and licensing information. The code is now clearly marked as being modified heavily for WLED.
13-16: Header includes updatedThe includes have been reorganized to include the necessary WLED-specific headers.
7673-7694: Effect management system improvedThe addEffect() function has been enhanced to:
- Find empty slots for new effects
- Prevent overwriting existing effects
- Handle vector resizing safely
- Return proper status codes
This is a good improvement that makes the effect system more robust and maintainable.
7696-7915: Effect registration system updatedThe setupEffectData() function has been reorganized to:
- Initialize the effect vector with static mode first
- Pre-allocate slots for all effects
- Register effects in a more organized way by category (1D, 2D, audio)
This organization makes the code more maintainable and easier to understand.
5072-5086: Audio reactive effects improvedThe audio reactive effects now have better:
- Volume sensitivity controls
- Frequency response mapping
- Peak detection
The audio reactivity improvements make the effects more dynamic and responsive.
4635-4642: Memory optimization for effectsThe code now includes memory optimizations for different platforms:
#ifdef ESP8266 #define LIGHTERS_AM 64 // max lighters (adequate for 32x32 matrix) #else #define LIGHTERS_AM 20 // max lighters #endifGood platform-specific optimizations to handle memory constraints.
also updates deprecated links that point the github wiki to point to https://kno.wled.ge/
Summary by CodeRabbit