Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmake package #91

Closed
wants to merge 1 commit into from
Closed

add cmake package #91

wants to merge 1 commit into from

Conversation

dand-oss
Copy link

From your cmake project

find_package(verdigris CONFIG REQUIRED)

target_link_libraries(${libname} PUBLIC
...
verdigris::verdigris
)

Todo

  • build and run tests and benchmarks

Build result

[0/1] Install the project...
-- Install configuration: "Release"
-- Up-to-date: INSTALLDIR/share/verdigris/cmake/verdigrisTargets.cmake
-- Up-to-date: INSTALLDIR/share/verdigris/cmake/verdigrisConfig.cmake
-- Up-to-date: INSTALLDIR/share/verdigris/cmake/verdigrisConfigVersion.cmake
-- Installing: INSTALLDIR/include/verdigris/wobjectcpp.h
-- Installing: INSTALLDIR/include/verdigris/wobjectdefs.h
-- Installing: INSTALLDIR/include/verdigris/wobjectimpl.h

From your cmake project
-----------------------

find_package(verdigris CONFIG REQUIRED)

target_link_libraries(${libname} PUBLIC
   ...
   verdigris::verdigris
   )

Todo
----
- build and run tests and benchmarks

Build result
------------

[0/1] Install the project...
-- Install configuration: "Release"
-- Up-to-date: INSTALLDIR/share/verdigris/cmake/verdigrisTargets.cmake
-- Up-to-date: INSTALLDIR/share/verdigris/cmake/verdigrisConfig.cmake
-- Up-to-date: INSTALLDIR/share/verdigris/cmake/verdigrisConfigVersion.cmake
-- Installing: INSTALLDIR/include/verdigris/wobjectcpp.h
-- Installing: INSTALLDIR/include/verdigris/wobjectdefs.h
-- Installing: INSTALLDIR/include/verdigris/wobjectimpl.h
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dan Dees seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ogoffart
Copy link
Member

I think the problem with the CLA assistant is that the email used in the git commit doesn't match the email registered in the GitHub account.

Copy link
Collaborator

@arBmind arBmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dand-oss Thank you for your PR.

Would it be possible/necessary to also express that Verdigris also requires a Qt5 or Qt6 to work as intended?

INTERFACE $<BUILD_INTERFACE:${${libname}_SOURCE_DIR}/lib>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)

target_compile_features(${libname} INTERFACE cxx_std_11)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd guess we need C++14 here.

@arBmind
Copy link
Collaborator

arBmind commented Jan 1, 2023

Please note: #99 adds full CMake support to Verdigris. That contains install package building and running all test targets.

@arBmind arBmind closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants