bot: use a logger properly, pass it to modules #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabled by default since it allows injecting errors basically
node-module-manager.js
Outdated
| @@ -85,6 +86,10 @@ me.loadModules = function(cb) { | |||
| me.initModules = function(cb) { | |||
| // Todo, don't ever init if they're already initted | |||
| _.each(_.values(modules), function(mod) { | |||
There was a problem hiding this comment.
Can you modify this loop to capture the key (module name) of each module? That would eliminate the moduleName function below.
23 tasks
|
I know this project aggressively follows "the code is the documentation" (right?) but could you say a few words in #144 about how to use the logger? |
It was redundant. This does introduce a new `module.exports._name` variable set for each module to keep track of that, but this doesn't seem too egregious.
This shows all supported options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LinuxMercedes This is the first pass at proper logging.
The big TODOs remaining are:
I'm fine punting those to future PRs since I think this is still somewhat better already