Made nickserv less async (fixes #95, part of #144). #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euank
requested changes
Nov 18, 2017
modules/nickserv.js
Outdated
| bot.getConfig('nickserv.json', function(err, conf) { | ||
| console.log(err); | ||
| if(err) return; | ||
| module.exports.init = (b) => { |
There was a problem hiding this comment.
This still needs to be a function, otherwise this.log won't work.
The bot calls init via something quite close to moduleInit.apply(moduleBot, moduleBot)
Here's the difference I'm meaning: https://runkit.com/euank/5a10b6c0bb407900127d67bd
conf/nickserv.example.json
Outdated
| "password" : "dicks" | ||
| "nickserv": "nickserv", | ||
| "password" : "dicks", | ||
| "successtext": "you are now identified for " |
There was a problem hiding this comment.
perhaps this should be a regexp? still a string in the config, but always passed to new RegExp and used with .test
brhoades
force-pushed
the
nickserv-less-async
branch
from
12677f8 to
a95bfda
Compare
Changed arrow func to function for logging. Now using regex for nickserv success message tests.
brhoades
force-pushed
the
nickserv-less-async
branch
from
a95bfda to
4bf3418
Compare
euank
approved these changes
Nov 19, 2017
gmackie
pushed a commit
to gmackie/EuIrcBot
that referenced
this pull request
Dec 16, 2017
…ale#172) Changed arrow func to function for logging. Now using regex for nickserv success message tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nickserv was previously async enough to identify after all channels were joined. I've now configured the module to retry joining channels if Nickserv sends us a notice with specific text (you are now identified). This isn't quite the workaround described in #95, but it works!
Also added logging in a few spots and removed tabs.
edit: cc #144