609 channel picker with shader

[B-LechCode]

No description provided.

[Stoppedpuma]

Colours don't seem to be accurate:

colour.webm

This is confirmed by both oculante as well as hyprpicker.

[B-LechCode]

Colours don't seem to be accurate:
colour.webm

This is confirmed by both oculante as well as hyprpicker.

Thank you! I see what I missed here.
Edit: I was too fast - I don't see the issue. I watched the RGBA values and the red channel is constant 1.0. Seems to be ok? The Red channel is between ff and fe there, your screenshot replicates these values to all channels?

Left: build from master, Right: build from my PR - no difference visible for me :)

[Stoppedpuma]

Colours don't seem to be accurate:
colour.webm
This is confirmed by both oculante as well as hyprpicker.

Thank you! I see what I missed here. Edit: I was too fast - I don't see the issue. I watched the RGBA values and the red channel is constant 1.0. Seems to be ok? The Red channel is between ff and fe there, your screenshot replicates these values to all channels?

Left: build from master, Right: build from my PR - no difference visible for me :)

Apologies, this was a late night review. I think I was confused by the hex value and other colour values being wrong. I was under the assumption that this would change the colour to update as well to that channel. Thinking about this now it wouldn't really make sense since it's just greyscale.

[Stoppedpuma]

The alpha channel seems to break the black border of the zoom window.

picker.webm

[B-LechCode]

The alpha channel seems to break the black border of the zoom window.
picker.webm

Thank you for this interesing bug. That's indeed a Problem, cause the shader doesn't do a distinction between border and normal texture.
I need to think about a possible fix and will come back then :)

@Stoppedpuma fixed it :)

[Stoppedpuma]

Functionally, this works fine. I'll leave actual code review to @woelper.

[Stoppedpuma]

Few obvious things as well as a clippy recommendation (clippy is being enforced going forwards).

[B-LechCode]

@woelper is it ok to merge, or do you want to have a look, too?

[woelper]

This is great work! I hope I have some time to review tonight!