Correctly(?) escape distribution names for wheels #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly, I can't really say for sure, as I don't know the codebase or what the project is trying to do. If you have a project name, you can get the correct wheel name by escaping as in the wheel spec. To that extent the first hunk of the code is using the correct escaping (although without tracking where |
|
Not a problem, totally understood. Thanks for your time, @pfmoore, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for
pip2pi, @wolever!Unfortunately, I found that it wasn't correctly escaping distribution names in wheels according to PEP 427:
pypa/pip#5006
Attached is patch that hopefully correctly fixes it. I know @pfmoore and @dstufft must be busy, but I would greatly appreciate it if they could very quickly review. Thanks, everyone!
Cc: @ofek @truthbk