wolfSSH Client with OpenSSH-format Keys #604

ejohnstown · 2023-10-16T17:25:50Z

Move the KeySignature struct around in internal.c so it can be used for a couple tasks.
Add decoder for the OpenSSH-format keys.
Add an identification function for the new key.
Update ReadKey to handle the new format.

src/internal.c

src/ssh.c

JacobBarthelmeh

Code changes look good. Thanks John! Only other thing is I see there is not a test yet. Hoping that we can add one of the keys to the wolfssh/keys directory and a basic test case.

1. Move the KeySignature struct around in internal.c so it can be used for a couple tasks. 2. Add decoder for the OpenSSH-format keys. 3. Add an identification function for the new key. 4. Update ReadKey to handle the new format.

1. Add two error codes for the new key format decoding. 2. Add in some better error and bound checking. 3. Fix ordering on a WOLFSSH_UNUSED and variable declaration. 4. Remove redundant ; from WOLFSSH_UNUSED function-like macro.

…ny type.

1. Add better error checking to the OpenSSH key code. 2. Add a couple heaps that were missing.

1. Change the block size in the key decoding to a named constant rather than a bare number. 2. Change the comparison from a difference of two unsigned values against zero to comparing them directly.

1. Add test keys. 2. Add API test for wolfSSH_ReadKey_buffer(). 3. Fix allocation issue found using the API test.

1. Rename and move CleanupUserAuthRequestPublicKey() as wolfSSH_KEY_clean(). 2. Restrict the number of keys allowed in an OpenSSH key package to 1. 3. Initialize the Rsa and Ecc keys right before getting them. 4. New error code for an OpenSSH key format error when decoding.

ejohnstown force-pushed the wolfssh-client-2 branch 2 times, most recently from 2a5da5f to ca6c50d Compare October 16, 2023 23:45

ejohnstown assigned JacobBarthelmeh Oct 17, 2023

ejohnstown requested a review from JacobBarthelmeh October 17, 2023 16:05

JacobBarthelmeh requested changes Oct 31, 2023

View reviewed changes

JacobBarthelmeh assigned ejohnstown and unassigned JacobBarthelmeh Oct 31, 2023

ejohnstown force-pushed the wolfssh-client-2 branch from 297ecf7 to a65c411 Compare November 2, 2023 16:52

ejohnstown requested a review from JacobBarthelmeh November 3, 2023 22:09

ejohnstown assigned JacobBarthelmeh and unassigned ejohnstown Nov 3, 2023

JacobBarthelmeh requested changes Nov 3, 2023

View reviewed changes

JacobBarthelmeh assigned ejohnstown Nov 3, 2023

ejohnstown force-pushed the wolfssh-client-2 branch 3 times, most recently from 97a41f5 to 1c33924 Compare November 6, 2023 21:52

ejohnstown added 7 commits November 6, 2023 14:07

wolfSSH Client with OpenSSH-format Keys

70aa287

1. Move the KeySignature struct around in internal.c so it can be used for a couple tasks. 2. Add decoder for the OpenSSH-format keys. 3. Add an identification function for the new key. 4. Update ReadKey to handle the new format.

wolfSSH Client with OpenSSH-format Keys

732aba4

1. Add two error codes for the new key format decoding. 2. Add in some better error and bound checking. 3. Fix ordering on a WOLFSSH_UNUSED and variable declaration. 4. Remove redundant ; from WOLFSSH_UNUSED function-like macro.

PR review: Update some std-C functions with the proper porting wrappers.

9bbfcf1

PR review: Fix potential memory leak when failing to parse a key of a…

8049606

…ny type.

PR Review

3b443c0

1. Add better error checking to the OpenSSH key code. 2. Add a couple heaps that were missing.

PR Review

23a9bb8

1. Change the block size in the key decoding to a named constant rather than a bare number. 2. Change the comparison from a difference of two unsigned values against zero to comparing them directly.

PR Review: Remove unused struct members from WS_KeySignature.

707104e

ejohnstown force-pushed the wolfssh-client-2 branch 2 times, most recently from 66d6c9a to d191292 Compare November 6, 2023 22:19

PR Review

dba9a6c

1. Add test keys. 2. Add API test for wolfSSH_ReadKey_buffer(). 3. Fix allocation issue found using the API test.

ejohnstown force-pushed the wolfssh-client-2 branch from d191292 to dba9a6c Compare November 6, 2023 23:17

ejohnstown requested a review from JacobBarthelmeh November 6, 2023 23:28

ejohnstown removed their assignment Nov 6, 2023

JacobBarthelmeh previously approved these changes Nov 7, 2023

View reviewed changes

JacobBarthelmeh assigned ejohnstown and unassigned JacobBarthelmeh Nov 9, 2023

ejohnstown dismissed JacobBarthelmeh’s stale review via 9214981 November 16, 2023 23:17

PR Review

ec1964d

1. Rename and move CleanupUserAuthRequestPublicKey() as wolfSSH_KEY_clean(). 2. Restrict the number of keys allowed in an OpenSSH key package to 1. 3. Initialize the Rsa and Ecc keys right before getting them. 4. New error code for an OpenSSH key format error when decoding.

ejohnstown force-pushed the wolfssh-client-2 branch from 9214981 to ec1964d Compare November 17, 2023 00:39

ejohnstown assigned JacobBarthelmeh and unassigned ejohnstown Nov 17, 2023

JacobBarthelmeh approved these changes Nov 17, 2023

View reviewed changes

JacobBarthelmeh merged commit b7aaabc into wolfSSL:master Nov 17, 2023
9 checks passed

ejohnstown deleted the wolfssh-client-2 branch November 17, 2023 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wolfSSH Client with OpenSSH-format Keys #604

wolfSSH Client with OpenSSH-format Keys #604

ejohnstown commented Oct 16, 2023

JacobBarthelmeh left a comment

wolfSSH Client with OpenSSH-format Keys #604

wolfSSH Client with OpenSSH-format Keys #604

Conversation

ejohnstown commented Oct 16, 2023

JacobBarthelmeh left a comment

Choose a reason for hiding this comment