Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Fixes #632

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Test Fixes #632

merged 1 commit into from
Dec 6, 2023

Conversation

ejohnstown
Copy link
Contributor

  1. Remove the grace period wolfSSHd test. It asks for a password, and when running as an action it doesn't have stdin, so it fails. The test works when stdin is available.
  2. Remove the check for __uint128_t from configure. wolfSSL exports this value, if present, in its options.h. After wolfSSL v5.6.4, wolfSSL also exports this to options.h when building it with CMake. The check in wolfSSH isn't necessary now.

@ejohnstown
Test Fixes
7e17dc9 
1. Remove the grace period wolfSSHd test. It asks for a password, and
   when running as an action it doesn't have stdin, so it fails. The
   test works when stdin is available.
2. Remove the check for __uint128_t from configure. wolfSSL exports this
   value, if present, in its options.h. After wolfSSL v5.6.4, wolfSSL
   also exports this to options.h when building it with CMake. The check
   in wolfSSH isn't necessary now.
@JacobBarthelmeh JacobBarthelmeh merged commit 3905a05 into wolfSSL:master Dec 6, 2023
@ejohnstown ejohnstown deleted the disable-grace branch December 6, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes

Assignees

@JacobBarthelmeh JacobBarthelmeh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejohnstown @JacobBarthelmeh