SSHD Banners #720
Merged
SSHD Banners #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add getting the banner option from the configuration file. Per the sshd_config(5) manpage, this is supposed to be a filename. 2. Load the banner file and set the banner into the CTX.
JacobBarthelmeh
previously requested changes
Jul 15, 2024
| { | ||
| if (banner != NULL && *banner != NULL) { | ||
| #ifndef NO_FILESYSTEM | ||
| freeBufferFromFile(*banner, NULL); |
There was a problem hiding this comment.
This should be in the config for the specific user I think. To handle something like this in the future:
Match User sshUser
Banner /path/to/specific_banner
There was a problem hiding this comment.
Opps sorry, looks like it is setup that way. Just init/free different than I expected. Please double check the XFREE call though after CleanupCTX (with *banner set to NULL here).
JacobBarthelmeh
dismissed
their stale review
No longer requesting changes, only comment to review the free of banner.
douzzer
approved these changes
Jul 16, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
SSHD Banners
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
SSHD Banners
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
SSHD Banners
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
SSHD Banners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Add support for loading banner files into wolfSSHd. (ZD 18156)
TESTING
Add "Banner filename.txt" to the sshd_config file used by wolfSSHd.