Use wolfCrypt SSHv2 KDF #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejohnstown
force-pushed
the
new-kdf
branch
4 times, most recently
from
5b795dc
to
86ce2bd
Compare
dgarske
requested changes
Jul 30, 2024
src/internal.c
Outdated
| @@ -47,6 +47,7 @@ | |||
| #include <wolfssl/wolfcrypt/ecc.h> | |||
| #include <wolfssl/wolfcrypt/hmac.h> | |||
| #include <wolfssl/wolfcrypt/signature.h> | |||
| #include <wolfssl/wolfcrypt/kdf.h> | |||
There was a problem hiding this comment.
Was this header always available? If not maybe do a version macro to support older wolfSSL releases? LIBWOLFSSL_VERSION_HEX >= WOLFSSL_V5_7_2?
1. Switching to use the new SSH-KDF function in wolfCrypt when the correct version of wolfSSL (v5.0.0 at a minimum) is used, when certified version of wolfCrypt is used or Kyber is disabled. 2. Add WOLFSSL_WOLFSSH to the wolfSSL user_settings files for the Zephyr testing.
dgarske
approved these changes
Jul 30, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
Use wolfCrypt SSHv2 KDF
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
Use wolfCrypt SSHv2 KDF
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Use wolfCrypt SSHv2 KDF
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Use wolfCrypt SSHv2 KDF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to use the new SSH-KDF function in wolfCrypt. Note, this only works in FIPS builds and/or when Kyber isn't used.