Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thingsboard/3.8.1-r3: cve remediation #36987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 13, 2024

Copy link
Contributor Author

octo-sts bot commented Dec 13, 2024

Gen AI suggestions to solve the build error:

• Detected Error: Multiple compilation failures related to missing Spring Framework classes (org.springframework.http, org.springframework.web.filter, etc.)

• Error Category: Dependency

• Failure Point: Maven compilation phase failing in http transport module

• Root Cause Analysis: The Spring Framework dependencies are missing from the Maven build. These are required for the HTTP transport module which uses Spring MVC components.

• Suggested Fix: Add Spring Boot and Spring Framework dependencies to the pombump pipeline:

- uses: maven/pombump
  with:
    add_dependencies: |
      <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-web</artifactId>
        <version>3.2.1</version>
      </dependency>
      <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-webmvc</artifactId>
        <version>6.1.2</version>
      </dependency>

• Explanation: The HTTP transport module uses Spring MVC annotations and classes for REST endpoints. Adding these dependencies will provide the required Spring Framework classes for compilation.

• Additional Notes:

  • Spring Boot starter web includes all necessary Spring MVC dependencies
  • Version numbers align with ThingsBoard 3.8.1 Spring dependencies
  • The transport module specifically needs Spring Web MVC support

• References:

@mamccorm mamccorm force-pushed the cve-thingsboard-5399dbbba2cdb49e7c0e8252b3b09e6a branch from 46548fe to d8cb3cb Compare December 14, 2024 20:55
Copy link
Contributor Author

octo-sts bot commented Dec 14, 2024

Gen AI suggestions to solve the build error:

• Detected Error: Multiple compilation failures related to missing Spring Framework dependencies, specifically:
package org.springframework.http does not exist
package org.springframework.web.filter does not exist

• Error Category: Dependency

• Failure Point: Maven compilation phase during build of http transport module

• Root Cause Analysis: The Spring Framework dependencies required for HTTP transport are missing from the project's Maven dependencies. This is a common issue when Spring Boot/Framework dependencies are not properly declared in the pom.xml.

• Suggested Fix: Add Spring Boot/Framework dependencies to the Maven build configuration in the pombump pipeline step:

- uses: maven/pombump
  with:
    add_dependencies: |
      <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-web</artifactId>
        <version>3.2.1</version>
      </dependency>
      <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-webmvc</artifactId>
        <version>6.1.2</version>
      </dependency>

• Explanation: The HTTP transport module uses Spring MVC annotations and classes for REST endpoints. Adding these dependencies will provide the required Spring Framework classes for compilation.

• Additional Notes:

  • Spring Boot starter web includes all necessary Spring MVC dependencies
  • Version numbers align with Spring Boot 3.x which is compatible with Java 17
  • These are compile-time dependencies needed for the HTTP transport module
  • No runtime impact on other modules that don't use Spring

• References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants