Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(osv): stop adding ID of record to "related" too #1365

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luhring
Copy link
Member

@luhring luhring commented Dec 10, 2024

The inclusion of the OSV record's ID as a related record was never necessary, and caused confusion downstream, such as on osv.dev.

@luhring
Copy link
Member Author

luhring commented Dec 10, 2024

cc: @andrewpollock @oliverchang @cpanato

@andrewpollock
Copy link

Will you retroactively correct existing records after this change?
(If yes, please ensure the modified field is updated also)

@luhring
Copy link
Member Author

luhring commented Dec 10, 2024

Will you retroactively correct existing records after this change? (If yes, please ensure the modified field is updated also)

Interesting, good callout. This is not accounted for in my change so far.

Today we take the latest "event" in our raw advisory data (e.g. this timestamp) and use it as the modified time, which won't change by virtue of modifying how we produce the OSV data from the same (unmodified) raw advisory data. So we probably need some sort of "or X, whichever is later" logic. 🤔

@luhring luhring marked this pull request as draft December 10, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants