Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake error on centos #111

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix cmake error on centos #111

merged 5 commits into from
Apr 12, 2024

Conversation

SunBeau
Copy link
Contributor

@SunBeau SunBeau commented Apr 11, 2024

Fix the error as shown below, when executing cmake on centos7
CMake Error

@wolkykim
Copy link
Owner

Thanks for the update. Looks like this is related to the change made with #108
Are there other platforms that might need some tests?

@wolkykim
Copy link
Owner

We like to include all the names of contributors as a celebration, please feel free to send a PR for the README update.

@SunBeau
Copy link
Contributor Author

SunBeau commented Apr 12, 2024

I have added and passed the multi-platform test

@wolkykim
Copy link
Owner

Thank you

@wolkykim
Copy link
Owner

Just a few questions before merging in.

  • I see this warning message. Is this something addressable easily?
    "Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/."

  • Do we need to run multiple tests per each version of OS? like ubuntu-2004, ubuntu-1804, ... Or is it ok to run the test on the latest version only? Like 1 test per OS except it's necessary?

  • Can Windows be included in the test?

@SunBeau
Copy link
Contributor Author

SunBeau commented Apr 12, 2024

  • I solved the warning by upgrading "actions/checkout" version for ubuntu-20.04/22.04.
  • I will get the errors as shown below because of GLIBC if I upgrade "actions/checkout" version for ubuntu-18.04/centos. Now I don't know how to solve it
  • Sometimes there are differences in different versions of the same system. I think more testing is better.
  • I'm not very good at Windows, maybe I'll try to support it in the future
    Snipaste_2024-04-12_14-43-50

@wolkykim
Copy link
Owner

Thank you for your contribution!

@wolkykim wolkykim merged commit 9734923 into wolkykim:main Apr 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants