Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for draft-6 examples #43

Closed
wants to merge 1 commit into from
Closed

add support for draft-6 examples #43

wants to merge 1 commit into from

Conversation

proppy
Copy link

@proppy proppy commented Jan 28, 2020

Fixes #42

wolverdude
wolverdude requested changes Apr 11, 2020
View reviewed changes
Copy link
Owner

@wolverdude wolverdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change the API for all the strategies. Instead, implement it in the base SchemaStrategy and only activate it if a schema is added with an examples keyword, similar to how the array/tuple distinction works.

@wolverdude
Copy link
Owner

I'll close this for now. If you create a new fix based on v1.2, submit a new PR.

@wolverdude wolverdude closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolverdude wolverdude wolverdude requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for draft-6 examples metadata
2 participants
@proppy @wolverdude