Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to dotnet standard #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesr981
Copy link

@jamesr981 jamesr981 commented Oct 23, 2024

This library was originally written in dotnet framework.
As a result, integrators are unable to use this library unless they are also using dotnet framework.

To allow for both dotnet framework and Dotnet, I have migrated the Dotnet client library to Dotnet Standard.

This involved a slight refactor to Json Deserialization.
Previously, a class JavascriptSerializer was being used. But this is exclusive to dotnet framwork.
Instead, I have installed System.Text.Json and created a little converter that handles the differences in deserialization between JavascriptSerializer and System.Text.Json.

As a result, there should be no breaking changes in this upgrade, but a major version bump should be done.

Not all of the unit tests passed for me as the credentials I have do not grant access to all the endpoints.

@jamesr981 jamesr981 marked this pull request as ready for review October 24, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant