This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Mini-Cart block conflict with Page Optimize and Product Bundles #9585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +120 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
danielwrobert
approved these changes
May 24, 2023
There was a problem hiding this comment.
LGTM! 🚀
This tests as described and I can confirm I am not seeing the error in Woo Core 7.7 and Woo Blocks 10.0.5 (via the provided zip).
Note: I see there's conversation in p1684930869348989-slack-C02FL3X7KR6 around the best approach for having a dedicated patch. Since this is urgent, I'll approve and we can follow up, if needed.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
4 tasks
|
Closing in favor of #9586. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9584.
This PR refactors how we lazy-load Mini-Cart scripts, so we check if that script has already been loaded in a Page Optimize bundle. #9584 is not reproducible in the latest version of WC Blocks, as the dependency that was causing an issue was removed in #9251. However, I think it's a good idea to merge this PR into
trunkinstead ofrelease/10.0, as the extra check can be beneficial to prevent potential future conflicts with Page Optimize.Testing
User Facing Testing
The issue is only reproducible in WC core 7.7 or WC Blocks 10.0.x. So please test with WC core 7.7 and this zip. (You can alternatively checkout the branch
release/10.0.0and cherry-pick the commit included in this PR)WooCommerce Visibility
Changelog