Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link payment issues #2959

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix Link payment issues #2959

merged 2 commits into from
Feb 29, 2024

Conversation

Mayisha
Copy link
Contributor

@Mayisha Mayisha commented Feb 28, 2024

Fixes #2958

Changes proposed in this Pull Request:

Link payment is failing in 2 places. In the block cart page and shortcode checkout page. We added some required field checks for the PRBs in #2886 which is causing the issue.

  • In block cart page, it was looking for the checkout fields. Added a early return there.
  • In shortcode checkout page, Jquery was picking up some fields from the Link pop-up. Added check for name and value field there to avoid the Link fields.

Testing instructions

  • Go to Stripe settings page and enable UPE.
  • Enabled Link.
  • As a shopper purchase a product from all of the following pages
  • Product
  • Shortcode cart
  • Shortcode checkout
  • Block cart
  • Block checkout
  • Purchases with Link from all the above pages should be successful without any error.

Additional testing

Test the steps from #2886 to make sure the required field issue did not resurface with the changes in this PR.

@Mayisha Mayisha changed the title fix link payment Fix link payment Feb 28, 2024
@Mayisha Mayisha changed the title Fix link payment Fix Link payment issues Feb 28, 2024
@a-danae a-danae self-requested a review February 28, 2024 20:09
Copy link
Contributor

@a-danae a-danae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix for this, @Mayisha !

Looks good to me but not approving yet as I'd like to take another look at the validation. Partial review for now.

Payment processing works fine in:

  • Product
  • Shortcode cart
  • Shortcode checkout
  • Block cart
  • Block checkout

I tested the field validation continue to work as expected and that seems okay. There's a behavior that's strange, but we're already having that in trunk and it's not critical. I'll open a separate issue for it.

Copy link
Contributor

@a-danae a-danae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

Validation continues to work both checkouts.

There's another unexpected behavior where the payment isn't processed in the block checkout when the company field isn't filled, but there's no company field. I can replicate this in trunk as well, so it wasn't introduced in this PR. All good with addressing it separately.

@Mayisha
Copy link
Contributor Author

Mayisha commented Feb 29, 2024

There's another unexpected behavior where the payment isn't processed in the block checkout when the company field isn't filled, but there's no company field.

I will check what might be causing the issue.

@Mayisha Mayisha merged commit ed774c8 into develop Feb 29, 2024
33 checks passed
@Mayisha Mayisha deleted the fix/2958-link-payment branch February 29, 2024 03:06
@a-danae
Copy link
Contributor

a-danae commented Feb 29, 2024

I will check what might be causing the issue.

Thanks! It already exists in trunk, so we can probably create a task for this and triage it along with the other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GlobalStep] "Payment failed. Please verify your information and try again" notice is displayed on cart page.
2 participants