Update translation for payment request settings section notice #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsingyuc
requested review from
a team and
wjrosa
and removed request for
a team
hsingyuc
force-pushed
the
update/translation
branch
from
107aa03 to
783a3f3
Compare
wjrosa
reviewed
Jan 27, 2025
| mixedString: __( | ||
| 'Some appearance settings may be overridden by the express payment section of the ' + | ||
| '{{checkoutPageLink}}Cart & Checkout blocks{{/checkoutPageLink}}. ' + | ||
| 'Follow the instructions there and check back soon.', |
There was a problem hiding this comment.
English is not my native language, but I am not sure this sentence is totally correct 🤔. I mean, especially the "check back soon" part.
There was a problem hiding this comment.
Nice! Thanks for fixing it. I think with the latest updates the changelog got messed up. Maybe this PR needs a rebase or something.
There was a problem hiding this comment.
Oops, you just did it. Everything is OK now 👍
wjrosa
approved these changes
Jan 27, 2025
hsingyuc
force-pushed
the
update/translation
branch
from
81d7fd8 to
d102ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
I've checked German, Swiss German, Spanish, and Japanese translations. The notice
Some appearance settings may be overridden by the express payment section of the Cart & Checkout blocks.is not translated, but the current translation is broken; this PR usesinterpolateComponentsto internationalize the string.Testing instructions
I'm not sure if there's a way to test this but maybe we can regenerate the po file and see if the text needs to be translated is included.
changelog.txtandreadme.txt(or does not apply)Post merge